Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lexical binding #36

Closed
joshbax189 opened this issue Oct 17, 2024 · 0 comments · Fixed by #37
Closed

Enable lexical binding #36

joshbax189 opened this issue Oct 17, 2024 · 0 comments · Fixed by #37

Comments

@joshbax189
Copy link
Contributor

joshbax189 commented Oct 17, 2024

See https://www.gnu.org/software/emacs/manual/html_node/elisp/Converting-to-Lexical-Binding.html

This blocks #10 (at least my implementation of the feature) and has been the default for a while now, so it's probably a worthwhile improvement.

After a quick look dynamic binding is used in a few places, so some functions may need params added, e.g. js-comint-start-or-switch-to-repl seems to need a way to temporarily set the program arguments NODE_PATH.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant