Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concession pricing not returned with billable items #201

Open
hagen opened this issue Feb 1, 2018 · 6 comments
Open

Concession pricing not returned with billable items #201

hagen opened this issue Feb 1, 2018 · 6 comments
Labels

Comments

@hagen
Copy link
Contributor

hagen commented Feb 1, 2018

Can concession prices for a billable_item be returned with the billable_item? This information cannot be sourced via. the API other than after being applied to an invoice_item.

@JohnColvin
Copy link
Member

We have a table that's the concession prices of billable items. I think the only thing here would be to figure out how we want to expose that info on the API. I'll have to check with some folks that are more familiar with this area.

@hagen
Copy link
Contributor Author

hagen commented Feb 1, 2018

Brilliant! Halfway there ;)
Considering that info is displayed at the Billable Items screen, my vote is to bundle them with. A billable_item would return its default price, and then an array of concession prices (with our without name?):

{
  "id": 1,
  "item_code": "0001",
  "item_type": "Service",
  "name": "Initial Consultation",
  "price": 80,
  "tax": {
    "links": {"self": "https://api.cliniko.com/v1/taxes/1"}
  },
  "concession_prices": [
    {
      "price": 70,
      "name": "Student",
      "links": {
        "self": "https://api.cliniko.com/v1/concession_types/221"
      }
    },
    {
      "price": 60,
      "name": "Senior",
      "links": {
        "self": "https://api.cliniko.com/v1/concession_types/227"
      }
     },
    {
      "price": null,
      "name": "Other",
      "links": {
        "self": "https://api.cliniko.com/v1/concession_types/228"
      }
     }
  ],
  "created_at": "2014-03-04T19:11:30Z",
  "updated_at": "2014-03-04T19:11:30Z",
  "links": {"self": "https://api.cliniko.com/v1/billable_items/1"}
}

@JohnColvin
Copy link
Member

👌 We were thinking something similar without the name.

@hagen
Copy link
Contributor Author

hagen commented Feb 8, 2018 via email

@JohnColvin
Copy link
Member

sure, we can make it a Monday 😏

@hagen
Copy link
Contributor Author

hagen commented Feb 10, 2018 via email

@JohnColvin JohnColvin mentioned this issue Apr 2, 2018
@hagen hagen added the request label Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants