Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens when court size is getting smaller #43

Open
ZvikaNaorCohen opened this issue Apr 19, 2023 · 2 comments
Open

What happens when court size is getting smaller #43

ZvikaNaorCohen opened this issue Apr 19, 2023 · 2 comments

Comments

@ZvikaNaorCohen
Copy link
Collaborator

Say we have a GameEvent that is supposed to happen in a few days, with 30 players want to participate.
The court size was 30 so everything works well.
But now, for some reason, the court size is getting smaller, for example to 20.
What should happen? Should we not allow decreasing the court size? Should we keep everything the same?

The issue is related to Court PR, and will be discussed in our next meeting.

@Danielsio
Copy link
Collaborator

Danielsio commented Apr 19, 2023

To my opinion this is some kind of a rare case, so in order to keep our implementaion simple we can assume thoes things won't happen.

In reality when it's happening we can leave it the the players to sort it out, if it's a soccer game, have the reserve teams wait on the bench, the loser team swaps out, and there you go..

Case of golf game or some sort of game where teams are not suppose to wait for their turn to participate it's indeed a problem. but is that our app fault ? how could the app know about that such a change in size of the max_players in the court ?

I'm open to hear other opinions.

@yftacherzog
Copy link
Contributor

yftacherzog commented Apr 20, 2023

Just want to mention that the fact that I asked for this issue to be created doesn't mean you necessarily have to address it. There are many times when valid issues are raised and they don't get to be attended - there are always going to be bugs. This one is a bug, but it might be that you decide not to fix it.

(I'll leave you to have your discussion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants