fix: corrected deprecated usage of ModuleLister.moduleAdded (#732) #740
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
adietish
changed the title
adietish
force-pushed
the
issue-732
branch
2 times, most recently
from
8120951 to
f6109f5
Compare
|
|
@adietish: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
ModuleListener#modulesAdded was added in IC-2022.3 and this PR thus requires us to bump the minimal version from (currently) |
I think we'll bump minimal version when 2024.1 will be out . |
|
I checked it and found out that I was wrong: the API required for this change only exists in |
|
@adietish this is still a warning on current 1.9.0 release. can you update this fix with latest main branch ? |
|
@sbouchet: we're currently still at |
|
|
@adietish what is the update on this PR ? |
|
@mohitsuman, @sbouchet: we're still at 2022.3: Do we want to bump so that we can include this PR? |
|
@adietish Are there any challenges in bumping ? |
|
And should we move this PR our of Draft state ? |
|
@mohitsuman @adietish : I propose to merge this PR after #889, bumping minimal version to 2023.1 . |
|
almost, there is still Integration UI test failures that @martinszuc is looking at |
…eveloper#732) Signed-off-by: Andre Dietisheim <[email protected]>
|
@sbouchet rebased it. |
|
|
as expected, minimal version check (22.3) failed. let's wait for minimal version bump before merging this one. |
(partially) fixes #732