feat: Declare server icon with icon attribute

Signed-off-by: azerr <[email protected]>
redhat-developer · Dec 12, 2023 · 138c28b · 138c28b
1 parent f3089d3
commit 138c28b
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 72 deletions.
diff --git a/...n/java/com/redhat/devtools/intellij/microprofile/lang/MicroProfileServerIconProvider.java b/...n/java/com/redhat/devtools/intellij/microprofile/lang/MicroProfileServerIconProvider.java
diff --git a/src/main/java/com/redhat/devtools/intellij/quarkus/lang/QuarkusIconProvider.java b/src/main/java/com/redhat/devtools/intellij/quarkus/lang/QuarkusIconProvider.java
@@ -24,7 +24,7 @@
  * Quarkus icon provider.
  */
 public class QuarkusIconProvider extends IconProvider {
-    public static final Icon QUARKUS_ICON = IconLoader.findIcon("/quarkus_icon_rgb_16px_default.png", QuarkusIconProvider.class);
+    public static final Icon QUARKUS_ICON = QuarkusIcons.Quarkus;
 
     @Nullable
     @Override

diff --git a/src/main/java/com/redhat/devtools/intellij/quarkus/lang/QuarkusIcons.java b/src/main/java/com/redhat/devtools/intellij/quarkus/lang/QuarkusIcons.java
@@ -0,0 +1,24 @@
+/*******************************************************************************
+ * Copyright (c) 2023 Red Hat, Inc.
+ * Distributed under license by Red Hat, Inc. All rights reserved.
+ * This program is made available under the terms of the
+ * Eclipse Public License v2.0 which accompanies this distribution,
+ * and is available at https://www.eclipse.org/legal/epl-v20.html
+ *
+ * Contributors:
+ * Red Hat, Inc. - initial API and implementation
+ ******************************************************************************/
+package com.redhat.devtools.intellij.quarkus.lang;
+
+import com.intellij.openapi.util.IconLoader;
+
+import javax.swing.*;
+
+/**
+ * Quarkus icons.
+ */
+public class QuarkusIcons {
+
+    public static final Icon Quarkus = IconLoader.findIcon("/quarkus_icon_rgb_16px_default.png", QuarkusIcons.class);
+
+}
diff --git a/src/main/java/com/redhat/devtools/intellij/quarkus/lang/QuarkusServerIconProvider.java b/src/main/java/com/redhat/devtools/intellij/quarkus/lang/QuarkusServerIconProvider.java
diff --git a/src/main/java/com/redhat/devtools/intellij/qute/lang/QuteLanguageSubstitutor.java b/src/main/java/com/redhat/devtools/intellij/qute/lang/QuteLanguageSubstitutor.java
@@ -58,17 +58,6 @@ public static boolean isQuteLibrary(@NotNull LibraryOrderEntry libraryOrderEntry
                 libraryOrderEntry.getLibraryName().contains("io.quarkus.qute:qute-core:");
     }
 
-    private Module findModule(VirtualFile file) {
-        for (Project project : ProjectManager.getInstance().getOpenProjects()) {
-            for (Module module : ModuleManager.getInstance(project).getModules()) {
-                if (ModuleUtilCore.moduleContainsFile(module, file, false)) {
-                    return module;
-                }
-            }
-        }
-        return null;
-    }
-
     @Override
     public @Nullable Language getLanguage(@NotNull VirtualFile file, @NotNull Project project) {
         Module module = LSPIJUtils.getModule(file, project);

diff --git a/src/main/resources/META-INF/lsp4ij-quarkus.xml b/src/main/resources/META-INF/lsp4ij-quarkus.xml
@@ -3,6 +3,7 @@
     <!-- Quarkus LSP -->
     <server id="microprofile"
             label="Tools for MicroProfile"
+            icon="com.redhat.devtools.intellij.microprofile.lang.MicroProfileIcons.MicroProfile"
             class="com.redhat.devtools.intellij.quarkus.lsp.QuarkusServer"
             clientImpl="com.redhat.devtools.intellij.quarkus.lsp.QuarkusLanguageClient"
             serverInterface="org.eclipse.lsp4mp.ls.api.MicroProfileLanguageServerAPI"
@@ -23,7 +24,6 @@
     <languageMapping language="JAVA"
                      serverId="microprofile"
                      documentMatcher="com.redhat.devtools.intellij.quarkus.lsp.QuarkusDocumentMatcherForJavaFile"/>
-    <serverIconProvider serverId="microprofile" class="com.redhat.devtools.intellij.microprofile.lang.MicroProfileServerIconProvider" />
   </extensions>
 
   <extensions defaultExtensionNs="com.intellij">

diff --git a/src/main/resources/META-INF/lsp4ij-qute.xml b/src/main/resources/META-INF/lsp4ij-qute.xml
@@ -4,6 +4,7 @@
     <!-- Qute LSP -->
     <server id="qute"
             label="Qute support"
+            icon="com.redhat.devtools.intellij.quarkus.lang.QuarkusIcons.Quarkus"
             class="com.redhat.devtools.intellij.qute.lsp.QuteServer"
             clientImpl="com.redhat.devtools.intellij.qute.lsp.QuteLanguageClient"
             serverInterface="com.redhat.qute.ls.api.QuteLanguageServerAPI"
@@ -32,7 +33,6 @@
     <languageMapping language="JAVA"
                      serverId="qute"
                      documentMatcher="com.redhat.devtools.intellij.qute.lsp.QuteDocumentMatcherForJavaFile"/>
-    <serverIconProvider serverId="qute" class="com.redhat.devtools.intellij.quarkus.lang.QuarkusServerIconProvider" />
   </extensions>
 
   <extensions defaultExtensionNs="com.intellij">