Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve start/stop of language servers #835

Closed
angelozerr opened this issue May 2, 2023 · 12 comments
Closed

Improve start/stop of language servers #835

angelozerr opened this issue May 2, 2023 · 12 comments
Assignees
Labels
bug Something isn't working lsp4ij LSP client for IJ
Milestone

Comments

@angelozerr
Copy link
Contributor

angelozerr commented May 2, 2023

related to #838

The start/stop of language servers should be improved to avoid some freezing and some weird behavior like #752

In otherwise I would like to fix:

I noticed that there are a lot of freeze and exceptions when I open a project, I close it, I reopen it and open another project, close them, etc quickly.

@angelozerr angelozerr added bug Something isn't working lsp4ij LSP client for IJ labels May 2, 2023
@angelozerr angelozerr self-assigned this May 2, 2023
@angelozerr angelozerr moved this to 📋 Backlog in IDE Cloudaptors May 2, 2023
@angelozerr angelozerr moved this from 📋 Backlog to 🏗 In progress in IDE Cloudaptors May 2, 2023
angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue May 2, 2023
angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue May 3, 2023
angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue May 3, 2023
angelozerr added a commit to angelozerr/intellij-quarkus that referenced this issue May 3, 2023
@angelozerr angelozerr added this to the 1.19.0 milestone May 9, 2023
@ia3andy
Copy link

ia3andy commented May 10, 2023

I had this problem on one of my projects where it also froze, I had to disable the plugin to make it work again. The project uses some advanced qute stuff which might not be yet handled by the plugin, but it should never freeze like this. This is really bad and should be taken seriously!

@ia3andy
Copy link

ia3andy commented May 10, 2023

image

@fbricon
Copy link
Contributor

fbricon commented May 10, 2023

@ia3andy we're taking those freezes very seriously. Expect the quality and performance of the intellij-quarkus plugin to improve dramatically in the coming weeks.

@ia3andy
Copy link

ia3andy commented May 10, 2023

@ia3andy we're taking those freezes very seriously. Expect the quality and performance of the intellij-quarkus plugin to improve dramatically in the coming weeks.

Ah that is a very good news, I am eager to give this a try :)

@angelozerr
Copy link
Contributor Author

Ah that is a very good news, I am eager to give this a try :)

Thanks for your patience!

Just one question, the freeze appears when:

  • you are editing a qute template?
  • you are closing editor?
  • you are closing a project?
  • you are closing IJ?

@ia3andy
Copy link

ia3andy commented May 10, 2023

Ah that is a very good news, I am eager to give this a try :)

Thanks for your patience!

Just one question, the freeze appears when:

  • you are editing a qute template?
  • you are closing editor?
  • you are closing a project?
  • you are closing IJ?

When I am opening a project containing qute templates, those qute templates are a bit exotic (fragment...)

@ia3andy
Copy link

ia3andy commented May 10, 2023

I've managed to open it someway and I've got a lot of this:
image
in the projects it seems

@angelozerr
Copy link
Contributor Author

've managed to open it someway and I've got a lot of this:

You are using Quarkus support from Jetbreains. This error desn't comes from intellij-quarkus.

So please tell me when freeze occurs.

@ia3andy
Copy link

ia3andy commented May 10, 2023

've managed to open it someway and I've got a lot of this:

You are using Quarkus support from Jetbreains. This error desn't comes from intellij-quarkus.

So please tell me when freeze occurs.

I am using both at the same time, let me disable the intellij one

@ia3andy
Copy link

ia3andy commented May 10, 2023

've managed to open it someway and I've got a lot of this:

You are using Quarkus support from Jetbreains. This error desn't comes from intellij-quarkus.
So please tell me when freeze occurs.

I am using both at the same time, let me disable the intellij one

image

new freeze

@fbricon
Copy link
Contributor

fbricon commented May 10, 2023

can you please take and share a thread dump whenever you see a freeze happening?

@angelozerr angelozerr moved this from 🏗 In progress to 👀 In review in IDE Cloudaptors May 17, 2023
@angelozerr
Copy link
Contributor Author

Performance and freeze problem should be fixed with #849

Please repoen if you find some again troubles

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in IDE Cloudaptors May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working lsp4ij LSP client for IJ
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants