Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-completion of Qute tags #975

Closed
ia3andy opened this issue Jun 26, 2023 · 7 comments · Fixed by #1006
Closed

Auto-completion of Qute tags #975

ia3andy opened this issue Jun 26, 2023 · 7 comments · Fixed by #1006
Assignees
Labels
bug Something isn't working completion lsp4ij LSP client for IJ
Milestone

Comments

@ia3andy
Copy link

ia3andy commented Jun 26, 2023

when using auto-completion of {#if for example, the closing tag is added with wrong indent:
image

I think it would be better to keep the snippet on one line and let the user decide of the rest.

@ia3andy
Copy link
Author

ia3andy commented Jun 26, 2023

also maybe put the cursor in the if (<> = cursor) {#if <>} and remove the condition placeholder

@angelozerr angelozerr transferred this issue from redhat-developer/quarkus-ls Jun 26, 2023
@angelozerr
Copy link
Contributor

I move this issue to IJ Quarkus since it is a bug in IJ Quarkus. Completion has so many bugs and I'm working on it.

The issue that you report is that;

  • IJ LSP cannot support LSP InsertTextMode.AdjustIndentation
  • IJ LSP cannot support snippet syntax.

@angelozerr angelozerr added bug Something isn't working lsp4ij LSP client for IJ completion labels Jun 26, 2023
@angelozerr angelozerr self-assigned this Jun 26, 2023
@angelozerr
Copy link
Contributor

@ia3andy before working on your issue I need to work on #787

@ia3andy
Copy link
Author

ia3andy commented Jun 26, 2023

@angelozerr no worries :) just reporting!

@fbricon
Copy link
Contributor

fbricon commented Jun 26, 2023

@ia3andy you can try the CI build from https://github.com/redhat-developer/intellij-quarkus/actions/runs/5376642773?pr=954, and overall keep an eye on #954

@angelozerr
Copy link
Contributor

angelozerr commented Jun 26, 2023

@ia3andy you can try the CI build from https://github.com/redhat-developer/intellij-quarkus/actions/runs/5376642773?pr=954, and overall keep an eye on #954

This build should fix indentation problem but not cursor position. Cursor position will be fixed when I will implement snippet support with completion. The main idea of this fix is to delegate indentation to Qute LS, but it should be better to support InsertTextMode.AdjustIndentation to let indentation process to the IJ LSP client.

@angelozerr
Copy link
Contributor

@angelozerr no worries :) just reporting!

Yes sure! I'm happy to work on issues expected by users:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working completion lsp4ij LSP client for IJ
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants