Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set project as workspace folder #1163

Merged

Conversation

angelozerr
Copy link
Contributor

fix: Set project as workspace folder

Fixes #1155

@fbricon
Copy link
Contributor

fbricon commented Sep 12, 2023

looks like the LS don't start anymore

@angelozerr
Copy link
Contributor Author

looks like the LS don't start anymore

which project are you testing?

@angelozerr angelozerr force-pushed the project-as-workspacefolder branch 2 times, most recently from 0268ae1 to f4020a3 Compare September 13, 2023 14:45
@fbricon
Copy link
Contributor

fbricon commented Sep 13, 2023

looks like the LS don't start anymore

which project are you testing?

Some project that didn't work on the main branch either. Except for the known multimodule issues with Qute projects, this PR looks fine, so I'm OK to merge

@angelozerr
Copy link
Contributor Author

This PR avoidd using file system watcher on ls side which blocks the ls when templates folder doesn't exist.

But we need to implement lsp watcher files because I think we will loose some features like if you have a template A which includes B with #include and you delete B without opening it it should retrigger validation and remove from cache the B template.

I need to test this feature.

@fbricon
Copy link
Contributor

fbricon commented Sep 14, 2023

so if you have a page.html with an include like

{#include include/somepage}

{/}

Now if you delete the include/ folder, no error shows at the include definition, unless you make a change to the page.

@fbricon
Copy link
Contributor

fbricon commented Sep 14, 2023

Similarly, if you have a so if you have a page.html with an include like

{#include include/somepage}

{/}

and the include/ folder doesn't exist, an error is shown at include/somepage, but if you ctrl+click on it, generate the missing template, the error doesn't go away

@angelozerr angelozerr marked this pull request as ready for review September 14, 2023 14:47
@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fbricon fbricon merged commit 25527ae into redhat-developer:main Sep 14, 2023
13 checks passed
@fbricon
Copy link
Contributor

fbricon commented Sep 14, 2023

Thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[regression] Create template codelens no longer works
2 participants