-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Set project as workspace folder #1163
fix: Set project as workspace folder #1163
Conversation
0282c97
to
9b21ec0
Compare
looks like the LS don't start anymore |
which project are you testing? |
0268ae1
to
f4020a3
Compare
Some project that didn't work on the main branch either. Except for the known multimodule issues with Qute projects, this PR looks fine, so I'm OK to merge |
This PR avoidd using file system watcher on ls side which blocks the ls when templates folder doesn't exist. But we need to implement lsp watcher files because I think we will loose some features like if you have a template A which includes B with #include and you delete B without opening it it should retrigger validation and remove from cache the B template. I need to test this feature. |
f4020a3
to
d9813d2
Compare
554b9d1
to
d4c7030
Compare
so if you have a page.html with an include like
Now if you delete the |
d4c7030
to
8ade4df
Compare
Similarly, if you have a so if you have a page.html with an include like
and the |
8ade4df
to
6910e8c
Compare
src/main/java/com/redhat/devtools/intellij/lsp4ij/client/LanguageClientImpl.java
Outdated
Show resolved
Hide resolved
Fixes redhat-developer#1155 Signed-off-by: azerr <[email protected]>
6910e8c
to
1d99aaf
Compare
Kudos, SonarCloud Quality Gate passed! |
Thanks @angelozerr! |
fix: Set project as workspace folder
Fixes #1155