perf: improve Quarkus wizard latency #1179

fbricon · 2023-09-25T17:54:46Z

Fixes #973
Fixes #273
Fixes #274
Signed-off-by: Fred Bricon [email protected]

src/main/java/com/redhat/devtools/intellij/quarkus/QuarkusConstants.java

src/main/java/com/redhat/devtools/intellij/quarkus/module/QuarkusCodeEndpointChooserStep.java

angelozerr · 2023-09-26T06:02:29Z

src/main/java/com/redhat/devtools/intellij/quarkus/module/QuarkusCodeEndpointChooserStep.java

@@ -102,7 +133,8 @@ public void actionPerformed(ActionEvent e) {
        this.customUrlWithBrowseButton.setButtonIcon(AllIcons.Actions.Preview);
        customPanel.addToCenter(this.customUrlWithBrowseButton);
        builder.addComponent(customPanel);
-        builder.addTooltip("Make sure your network connection is active before continuing.");
+        builder.addTooltip("Make sure your network connection is active.");


Use QuarkusBundle message

src/main/java/com/redhat/devtools/intellij/quarkus/module/QuarkusCodeEndpointChooserStep.java

fbricon · 2023-09-26T10:09:15Z

I broke QuarkusModelRegistryTest somehow, need to fix it

.../java/com/redhat/devtools/intellij/quarkus/projectWizard/QuarkusCodeEndpointChooserStep.java

src/main/java/com/redhat/devtools/intellij/quarkus/projectWizard/QuarkusModelRegistry.java

src/main/java/com/redhat/devtools/intellij/quarkus/projectWizard/QuarkusModuleInfoStep.java

angelozerr · 2023-09-26T17:35:45Z

@fbricon the performance are impressive! congrats!

The PR is very good but here some improvement that we could do for wizard (perhaps in an another PR):

when you fill artifactid at this step:

I think it should update project name too:

I don't understand the custom url? Do you think we could prefill with some values?

angelozerr · 2023-09-26T17:52:14Z

What about simplifying the ui wizard page with URL by having just à combo URL prefilled with default value?

fbricon · 2023-09-26T18:01:36Z

What about simplifying the ui wizard page with URL by having just à combo URL prefilled with default value?

I have a different but similar approach in mind, but I put that aside for now as it was a bit complicated to achieve.
A simple pre-filled combo doesn't work as you can't simply reset it to the default value if you delete it.

I opted to focus on the performance aspect in this PR. Other improvements can and will be done separately.

Signed-off-by: Fred Bricon <[email protected]>

sonarcloud · 2023-09-26T18:17:28Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
15.5% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

angelozerr · 2023-09-26T22:00:26Z

It works like a charm and wizard are so fast now!

Thanks so much @fbricon to have implemented the artifact id which updates project name.

angelozerr · 2023-09-26T22:01:10Z

I opted to focus on the performance aspect in this PR. Other improvements can and will be done separately.

Yes sure! I wanted just to share with you my first feeling that I add by playing with the wizard.

openshift-ci bot added the do-not-merge/work-in-progress label Sep 25, 2023

fbricon force-pushed the faster-wizard branch 4 times, most recently from 8654cc0 to 187eac4 Compare September 25, 2023 18:05