Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Improve performance of Quarkus deployment jar support #1221

Merged
merged 1 commit into from
Oct 16, 2023
Merged

perf: Improve performance of Quarkus deployment jar support #1221

merged 1 commit into from
Oct 16, 2023

Conversation

angelozerr
Copy link
Contributor

perf: Improve performance of Quarkus deployment jar support

Fixes #1143

@angelozerr angelozerr mentioned this pull request Oct 10, 2023
Closed
@angelozerr angelozerr force-pushed the quarkus-deployment-perf branch 3 times, most recently from f2da00a to 447fa4c Compare October 10, 2023 16:49
@angelozerr angelozerr mentioned this pull request Oct 11, 2023
Closed
@angelozerr
Copy link
Contributor Author

This PR update the classpath of a module by adding Quarkus deployment dependencies when getProjectInfo is called (when there is completion, validation, etc application.properties or when JSON Schema for application.yaml must be generated).

Before this PR the update of classpath was done when a module was added or when they were a classpath changes (which should fix #1190)

The main problem is performance. I needto investigate more

@angelozerr angelozerr mentioned this pull request Oct 12, 2023
Closed
@angelozerr angelozerr force-pushed the quarkus-deployment-perf branch 2 times, most recently from 795cfbc to 3e9071c Compare October 13, 2023 13:05
@fbricon
Copy link
Contributor

fbricon commented Oct 13, 2023 •
edited
Loading

Please incorporate these changes as well, as Runtime is the proper scope to put these deployment jars in (they won't leak in the module classpath)

https://github.com/redhat-developer/intellij-quarkus/pull/1080/files#diff-d93703e9bbc07cc4fbff6e3d1fd328ffd7bca49de838ff3280638b87cef9b376R157-R165

https://github.com/redhat-developer/intellij-quarkus/pull/1080/files#diff-a087cafb41371f5153e6a5191687391fb0728bf0d6777e285f6317423564f34aR126

@angelozerr angelozerr force-pushed the quarkus-deployment-perf branch 2 times, most recently from 10f0aba to abf5cde Compare October 13, 2023 16:52
@angelozerr
Copy link
Contributor Author

Please incorporate these changes as well, as Runtime is the proper scope to put these deployment jars in (they won't leak in the module classpath)

integrated.

@angelozerr angelozerr marked this pull request as ready for review October 13, 2023 16:53
@angelozerr angelozerr force-pushed the quarkus-deployment-perf branch 8 times, most recently from 3ed7c40 to 30ce944 Compare October 16, 2023 08:22
This was referenced Oct 16, 2023
Closed
Closed
@angelozerr angelozerr force-pushed the quarkus-deployment-perf branch 2 times, most recently from dcf6b2c to 6e20c8e Compare October 16, 2023 14:04
@angelozerr
Copy link
Contributor Author

Ci build for Linux is working!

@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@fbricon fbricon merged commit f1f19b8 into redhat-developer:main Oct 16, 2023
13 checks passed
@fbricon
Copy link
Contributor

fbricon commented Oct 16, 2023

Thanks @angelozerr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance of Quarkus deployment jar support
2 participants
@angelozerr @fbricon