Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: don't get document when file is opened #1229

Merged
merged 1 commit into from
Oct 17, 2023
Merged

perf: don't get document when file is opened #1229

merged 1 commit into from
Oct 17, 2023

Conversation

angelozerr
Copy link
Contributor

This PR removes the code which get the Document from the given file because:

  • LSP API workw now with VirtualFile instead of Document (we don't need it)
  • getting Document from a VirtualFile requires to be in read action mode.

@angelozerr angelozerr self-assigned this Oct 16, 2023
@angelozerr angelozerr added this to the 1.29.0 milestone Oct 16, 2023
@angelozerr angelozerr added lsp4ij LSP client for IJ performance labels Oct 16, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@fbricon fbricon merged commit 5dc6ca0 into redhat-developer:main Oct 17, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon Awaiting requested review from fbricon

Assignees

@angelozerr angelozerr

Labels
lsp4ij LSP client for IJ performance
Projects
None yet
Milestone
1.29.0
Development

Successfully merging this pull request may close these issues.
2 participants
@angelozerr @fbricon