fix: Remove LSPIJUtils.getProject(VirtualFile file) #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: azerr <[email protected]>
angelozerr
force-pushed
the
gradle_qute_support
branch
from
5a1c9ba
to
bdcb89d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
fbricon
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LSPIJUtils.getProject(file)return a project fora given file which is wrong because a file (instance) can belong to several projects (if the same file is opened in different project).LSPIJUtils.getModule(file)loops for all opened project and return the module which contains the file for the first opened project. In otherwise this method could return a Module which belong to a project which is not correct.Those 2 methods should be removed.