Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Declare server icon with icon attribute #1288

Merged
merged 1 commit into from
Dec 12, 2023
Merged

feat: Declare server icon with icon attribute #1288

merged 1 commit into from
Dec 12, 2023

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Dec 12, 2023 •
edited
Loading

feat: Declare server icon with icon attribute

This PR requires redhat-developer/lsp4ij#40

@angelozerr angelozerr marked this pull request as ready for review December 12, 2023 15:06
@angelozerr angelozerr added the enhancement New feature or request label Dec 12, 2023
@angelozerr angelozerr added this to the 1.31.0 milestone Dec 12, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@fbricon fbricon merged commit 138c28b into redhat-developer:main Dec 12, 2023
8 checks passed
@fbricon
Copy link
Contributor

fbricon commented Dec 12, 2023

thx @angelozerr

@fbricon fbricon modified the milestones: 1.31.0, 1.31.1 Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon fbricon left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@angelozerr @fbricon