-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide a language servers console like vscode (#838) #849
Conversation
9e857c8
to
528e9b4
Compare
It start sworking! Here a little demo with the LSP console: Please note that my code is very ugly, so please don't review it. I have aligned the start/stop of language server with LSP4E and now I have the LSP console I have fixed a lot of bugs. For the moment I have never seen some freeze and I have less error traces. The error kind that I see is:
I have fixed too a problem when you open, close project it will never disconnect to a messahe bus and we will have so many events which was fired. |
ba47080
to
bb6052a
Compare
e69f918
to
161cd95
Compare
src/main/java/com/redhat/devtools/intellij/quarkus/lsp4ij/LanguageServersRegistry.java
Outdated
Show resolved
Hide resolved
src/main/java/com/redhat/devtools/intellij/quarkus/lsp4ij/console/LanguageServerExplorer.java
Outdated
Show resolved
Hide resolved
29b321a
to
2b825b3
Compare
ccf4235
to
7e12053
Compare
...vtools/intellij/quarkus/lsp4ij/console/explorer/LanguageServerExplorerLifecycleListener.java
Show resolved
Hide resolved
...vtools/intellij/quarkus/lsp4ij/console/explorer/LanguageServerExplorerLifecycleListener.java
Show resolved
Hide resolved
...vtools/intellij/quarkus/lsp4ij/console/explorer/LanguageServerExplorerLifecycleListener.java
Show resolved
Hide resolved
...vtools/intellij/quarkus/lsp4ij/console/explorer/LanguageServerExplorerLifecycleListener.java
Show resolved
Hide resolved
bd32905
to
c8cf525
Compare
src/main/java/com/redhat/devtools/intellij/microprofile/lang/MicroProfileIcons.java
Show resolved
Hide resolved
571c668
to
28efe86
Compare
27703d6
to
8c84ddd
Compare
There is this error when I close projetc and LSP consoleis activated #862 but I thik we can live with this error for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a shortcoming where the log output would only show up once I restarted the IDE.
Steps:
- ASSERT: have a clean build, Trace for Qute and Microprofile are off
- EXEC: run the IDE and turn both to verbose in the settings
- EXEC: open the "Language Servers" tool window
- ASSERT: "Tools for Microprofile" is not running, no output is shown
- EXEC: edit a java file and see if "Tools for Microprofile" is turned to "started" and see if there's log output
Result:
It doesnt turn to "started" and there's no log output for me. It only works as expected (steps above) once I restart the IDE.
Same is true for "Qute support" for me
Nevertheless, things work well enough to be merged and this PR especially eliminates freezes. Should be thus merged, shortcoming solved afterwards.
LGTM
Thanks so much @adietish for your great review, I created your issue at redhat-developer/lsp4ij#21 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
…r#838) Fixes redhat-developer#838 Signed-off-by: azerr <[email protected]>
feat: Provide a language servers console like vscode (#838)
Fixes #838
To activate LSP console for a given LS, open the
Language Servers
settings and select message or verbose in the trace comboAfter that when LS will be started you will see the lifecycle of the LS (starting stopping, etc)
and the LSP traces on the right.