Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of compute of Qute data model with binary #899

Open
angelozerr opened this issue Jul 12, 2023 · 0 comments
Open

Improve performance of compute of Qute data model with binary #899

angelozerr opened this issue Jul 12, 2023 · 0 comments
Assignees

Comments

@angelozerr
Copy link
Contributor

angelozerr commented Jul 12, 2023

Today when a Java source file is saved, it evicts the Java cache of Qute which stores information of Java source and binary classes (ex : Integer String have some methods) to use it with completion.

It means that each time you save a Java file source (in IJ it is not on saved but on change of Java file), it evict the cache from Java sources and binary classes and it compute again the data model from sources and binary (ex : it scans JAR to collect Qute renarde user tags, it collect again methods of String).

You can notice that by seeing LSP console which collect information about String, Collection, etc after a Java source change although the cache should not evict binary classes:

..

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (54)'
Params: {
  "className": "java.util.List",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (60)'
Params: {
  "className": "java.util.Collection",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (61)'
Params: {
  "className": "java.util.Collection",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (62)'
Params: {
  "className": "java.lang.Iterable",
  "projectUri": "quarkus-blast"
}


[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (63)'
Params: {
  "className": "java.lang.Iterable",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (64)'
Params: {
  "className": "java.util.Collection",
  "projectUri": "quarkus-blast"
}

[Trace - 01:45:50 PM] Received request 'qute/template/resolvedJavaType - (65)'
Params: {
  "className": "java.lang.Iterable",
  "projectUri": "quarkus-blast"
}

The evict cache must be improved to evict only data model of Java sources and not of binary when a Java file is saved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant