Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Qute support for multi module project #930

Closed
angelozerr opened this issue Sep 14, 2023 · 2 comments · Fixed by #940
Closed

Qute support for multi module project #930

angelozerr opened this issue Sep 14, 2023 · 2 comments · Fixed by #940
Assignees
@angelozerr
Labels
bug Something isn't working qute
Milestone
0.17.0

Comments

@angelozerr
Copy link
Contributor

When project contains multi-module with some projects which are Qute project, it doesn't work, because today we consider that a workspace folder is a project which is wrong, because a workspace folder could contains several maven module which could be a Qute project.

To fix that we need to:

  • not use workspace folder to load Qute project
  • having on JDT / IJ side a new services:
    • java/qute/projects request -> return all Qute projects from rootUri
    • java/qute/projectAdded / java/qute/projectRemoved notifications to notify the language server that a new Qute project has been added/removed from the workspace.
@angelozerr angelozerr added bug Something isn't working qute labels Sep 14, 2023
@angelozerr angelozerr self-assigned this Sep 14, 2023
@angelozerr angelozerr mentioned this issue Sep 14, 2023
Closed
@angelozerr
Copy link
Contributor Author

Here a sample multi-qute.zip which fails on vscode, IJ, Eclipse IDE

@angelozerr
Copy link
Contributor Author

The sample redhat-developer/intellij-quarkus#1164 (comment) show that we need to load qute project with dependencies

angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 19, 2023
@angelozerr
Qute support for multi module project
8f4886d 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/vscode-quarkus that referenced this issue Sep 19, 2023
@angelozerr
Qute support for multi module project
9a44fc5 
See redhat-developer/quarkus-ls#930

Signed-off-by: azerr <[email protected]>
This was referenced Sep 19, 2023
Merged
Draft
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 19, 2023
@angelozerr
Qute support for multi module project
12396c9 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 19, 2023
@angelozerr
Qute support for multi module project
c5ec2e7 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 21, 2023
@angelozerr
Qute support for multi module project
67a229b 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 21, 2023
@angelozerr
Qute support for multi module project
2ee9cc2 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 21, 2023
@angelozerr
Qute support for multi module project
5719ac0 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 21, 2023
@angelozerr
Qute support for multi module project
c8de48e 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
angelozerr added a commit to angelozerr/quarkus-ls that referenced this issue Sep 21, 2023
@angelozerr
Qute support for multi module project
1ebac0a 
Fixes redhat-developer#930

Signed-off-by: azerr <[email protected]>
fbricon pushed a commit that referenced this issue Sep 22, 2023
@angelozerr @fbricon
Qute support for multi module project
4a209b1 
Fixes #930

Signed-off-by: azerr <[email protected]>
@rgrunber rgrunber added this to the 0.17.0 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@angelozerr angelozerr

Labels
bug Something isn't working qute
Projects
IDE Raptors
Archived in project
Milestone
0.17.0
Development

Successfully merging a pull request may close this issue.

Qute support for multi module project angelozerr/quarkus-ls
2 participants
@rgrunber @angelozerr