Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties should be available recursively #939

Open
gbourant opened this issue Sep 16, 2023 · 5 comments
Open

Properties should be available recursively #939

gbourant opened this issue Sep 16, 2023 · 5 comments
Labels
enhancement New feature or request qute

Comments

@gbourant
Copy link

Assume you have 3 tags:

  1. inputLabelText.html
       {#inputLabel /}
       {#inputText  /}
  1. inputLabel.html
<label {#if for??}for="{for}"{/if}>
        {title??}
</label>
  1. inputText.html
<input {#if value??}value="{value}"{/if} />

So when the inputLabelText.html is used {#inputLabelText /} the properties of the other tags are not available for auto completion.

@angelozerr angelozerr added enhancement New feature or request qute labels Sep 18, 2023
@angelozerr
Copy link
Contributor

If I understansd you can write

{#inputLabelText title="foo" /}

Are you sure with that?

@gbourant
Copy link
Author

gbourant commented Sep 18, 2023

Yeap, it seems that it doesn't work.

You can see the attached imaged but also i updated the project here.
SC_20230918_102335_23805

Also, I do not know if this relevant to this project but the highlight breaks when the property value has a space.

@angelozerr
Copy link
Contributor

I didnt' know that we could write this kind of user tag. That's very strange because if title has different type from different user tag you will have some error.

@mkouba is it an expected behavior?

Also, I do not know if this relevant to this project but the highlight breaks when the property value has a space.

I think it is a bug from our Qute parser, we need to fix it.

Those 2 issues comes from the Qute Language Server and are not linked to IJ himself (I mean that we will have the same problem for vscode and Eclipse IDE)

@angelozerr angelozerr transferred this issue from redhat-developer/intellij-quarkus Sep 18, 2023
@angelozerr
Copy link
Contributor

@gbourant I moved your issue in quarkus-ls github project since your 2 issues comes from Qute LS.

@mkouba
Copy link
Collaborator

mkouba commented Sep 19, 2023

@mkouba is it an expected behavior?

I'm not quite sure what behavior do you mean?

I don't think that args/parameters of a user tag should be validated at all because tags that are not executed in isolation can access data from the parent context.

Note that in Quarkus 3.5 there's a breaking change - a user tag is now executed as an isolated template by default (unlike in previous versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request qute
Projects
None yet
Development

No branches or pull requests

3 participants