Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relaxed plugin validation and errors (false positive) #960

Open
ia3andy opened this issue Jun 28, 2024 · 1 comment
Open

Relaxed plugin validation and errors (false positive) #960

ia3andy opened this issue Jun 28, 2024 · 1 comment

Comments

@ia3andy
Copy link

ia3andy commented Jun 28, 2024

I do believe that it is essential for the Quarkus plugin to be relaxed about raising errors when they are not 100% sure (totally avoiding false positive).

The plugin is here as a helper to make things easier and quicker, the validation is a nice to have (and should be best effort). When there is the question of raising an error, the plugin should:

  • if this is a guaranteed error, raise it
  • if this is a possible error or missing value, show a very light warning

Anyway Quarkus build is here as backup to make sure everything is fine for the user.

This is a false positive:
image

This is a good weak warning:
image

@ia3andy
Copy link
Author

ia3andy commented Jun 28, 2024

For the false positive, I think the issue is that the method returns a generic type T which is not accepted by the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant