-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Qute is now supporting fragments #563
Comments
Thanks for reporting this issue. We need to implement it. |
@mkouba how do you sync new features with the tooling teams? Maybe those should be anticipated? |
Yes they should :-) |
Unfortunately, there is no sync process at the moment. I believe that we should just file a new issue here when a new feature lands in the main branch? FTR Type-safe Fragments: https://quarkus.io/guides/qute-reference#type_safe_fragments |
@fbricon if we create an issue here, is this synced in the team for all IDEs plugins? |
If the work only involves development on the https://github.com/redhat-developer/quarkus-ls side, then all IDEs will automatically reap the benefits. VS Code is the 1st consumer, Eclipse and IntelliJ will pick it up eventually. |
For fragment it will require some work on JDT LS side, so @jeffmaury will need to do the same thing for IJ. I have the intention to work on this issue. |
@ia3andy in your sample I have the impression that when you write $ in method of TemplateInstance it defines the fragment id (noteList). Is it corect? I have not found some documentation which explains that in https://quarkus.io/guides/qute-reference#fragments Which support of fragment are you expecting? |
I believe that this is documented in the Type-safe Fragments section (it's a quarkus-specific feature). |
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
Thanks for your clarification @mkouba I started the support of fragment with redhat-developer/quarkus-ls#768 You can notice that cmpletion, hover of section show now link(s) of the documentation It will avoid for newbie (like me) to forget some part of documentation. |
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
@ia3andy is it possible to share your project with fragment please, in order to that I play with it. Thanks. |
See #563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
@mkouba @ia3andy you can see a demo with my current work for fragment support at redhat-developer/quarkus-ls#769 (comment) Please add comments in this PR if you need some improvement , another features for fragment support, etc. Thanks. |
@angelozerr sorry for the delay, here is the project: https://github.com/ia3andy/renotes/ |
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
Thanks so much @ia3andy I will try with your project to see if there are not some usecases that I could miss. |
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
See redhat-developer/vscode-quarkus#563 Signed-off-by: azerr <[email protected]>
It seems VSCode extension doesn't support this yet.
See https://quarkus.io/guides/qute-reference#fragments
cc @mkouba
The text was updated successfully, but these errors were encountered: