Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into removing the public_vlan var #389

Open
akrzos opened this issue Oct 5, 2023 · 2 comments
Open

Look into removing the public_vlan var #389

akrzos opened this issue Oct 5, 2023 · 2 comments

Comments

@akrzos
Copy link
Member

akrzos commented Oct 5, 2023

It is not clear to me this is in use anymore and is a rather confusing var. We should seek to remove it to avoid confusion.

@dbutenhof
Copy link
Collaborator

@akrzos You apparently started this in #485 but gave up, suggesting this is more complicated than it might seem at first glance. Can you share more context?

@akrzos
Copy link
Member Author

akrzos commented Jun 5, 2024

I didn't have the means to test it. The public_vlan var is confusing and could actually be entirely done away with if we made SNOs deploy on the private network by default, such that their networking matched that of MNO/BM clusters. Also this matching would make it easier to maintain. If we deem it necessary, they we should have a var for use_public_lab_dhcp and that would place the SNO on the public lab's dhcp network instead (This is the default today).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants