Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Advertise p-p-d compatibility D-Bus interface under UPower namespace #683

Open
jpetso opened this issue Sep 2, 2024 · 3 comments · May be fixed by #684
Open

Advertise p-p-d compatibility D-Bus interface under UPower namespace #683

jpetso opened this issue Sep 2, 2024 · 3 comments · May be fixed by #684

Comments

@jpetso
Copy link

jpetso commented Sep 2, 2024

UPower starting with release 0.20 is advertising itself on D-Bus as 'org.freedesktop.UPower.PowerProfiles' following its move into the UPower umbrella. The previous 'net.hadess.PowerProfiles' interface is still kept for compatibility reasons, but might be removed in the future - e.g. openSUSE tried to remove it immediately, but couldn't.

I'm just a bypasser looking out for compatibility concerns. If I'm reading the tuned-ppd source correctly, the compatibility interface is advertised under the old name only. If the new name isn't advertised, users of the interface will stick to the old one and there isn't any upgrade path, despite the upstream project endorsing the new interface within UPower.

So it would be nice if tuned-ppd also advertised both, or if in doubt, perhaps only the current one instead of the previous one.
@Conan-Kudo
Copy link

This is actually going to need to be a requirement for tuned to replace ppd in Fedora 41...

@yarda
Copy link
Contributor

yarda commented Sep 2, 2024

Good catch, @zacikpa could you handle it?

@zacikpa
Copy link
Contributor

zacikpa commented Sep 2, 2024

Sure, will do.

zacikpa added a commit to zacikpa/tuned that referenced this issue Sep 3, 2024
@zacikpa
tuned-ppd: Support the new UPower PPD namespace
17d7044 
Since version 0.20, power-profiles-daemon exposes
its DBus interface under "org.freedesktop.UPower.PowerProfiles"
alongside the previous name. To be compatible with PPD, this commit
implements the same change into tuned-ppd.

Resolves: redhat-performance#683
@zacikpa zacikpa linked a pull request Sep 3, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tuned-ppd: Support the new UPower PPD namespace zacikpa/tuned
4 participants
@jpetso @Conan-Kudo @yarda @zacikpa