uncore: Allow to configure frequency limits using percent #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgruszka
force-pushed
the
uncore_percent
branch
from
f44bb8b
to
4ae5921
Compare
sgruszka
changed the title
sgruszka
force-pushed
the
uncore_percent
branch
from
4ae5921
to
dcc2640
Compare
yarda
requested changes
May 23, 2024
|
What about using unit suffix to distinguish between percentage and kHz? Then we could avoid the possible conflict between kHz and percentage setting. E.g. we used something similar in |
Sorry for delay, I was busy with other project. Yes, suffix makes perfect sense, will update. |
Using direct frequency values in only useful in specialistic profiles where we know target platform. Allow to configure uncore frequency as percent of hardware maximum/minimum frequency. Such parameters can be used in generic profiles like 'balanced' in portable way, for example: [uncore] max_freq_khz=90% Signed-off-by: Stanislaw Gruszka <[email protected]>
|
@yarda I made the update, please check. Not sure why test are failing now, I think it's issue with CI. |
yarda
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using direct frequency values in only useful in specialistic profiles
where we know target platform. Allow to configure uncore frequency as
percent of hardware maximum/minimum frequency. Such parameters can be
used in generic profiles like 'balanced' in portable way, for example:
[uncore]
max_freq_khz=90%