Tuned ppd adjustments #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And adjust the systemd service file to log to /var/log/tuned/tuned-ppd.log by default. Additionally, add an option to turn on debug level logging.
The daemon does not write its PID to any file.
Related: rhbz#2292636
- Only use the default profile from the configuration file if TuneD is not already running with an active profile. This makes the daemon "recall" the active profile after a restart. - Make sure that SIGHUP completely resets the daemon, including resetting the 'battery' and 'performance_degraded' status.
The profile may not change, so do not log that we are switching a profile.
|
Added 3 more commits, most importantly an update which makes |
yarda
approved these changes
Jul 23, 2024
| # start tuned-ppd right away | ||
| if [ -f %{_localstatedir}/lib/rpm-state/tuned/ppd-active ]; then | ||
| systemctl start tuned-ppd | ||
| rm -rf %{_localstatedir}/lib/rpm-state/tuned |
There was a problem hiding this comment.
This will probably trigger rpmlint warning, thus it's better to do rm -f and then rmdir, but this is minor problem that can be ignored/waived or fixed later.
|
Rawhide CI failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces small changes in and related to
tuned-ppd:/var/log/tuned/tuned-ppd.log).power-profiles-daemonfortuned-ppd, scriptlets now check whether PPD is running and if yes,tuned-ppdis also started right away.