API URL to become a variable for GitHub Enterprise

[lythro10]

Type of issue

Feature Request

Description

Currently, this app cannot be used on GitHub enterprise versions which are self hosted, because the Base API URL is set to the default API of github.com

As GitHub Enterprise is self-hosted the API URL is different.

Describe the solution you'd like

A solution would be to create a configuration option for the API URL as a not required field which the default would be github api if not specified.

I would like to be assigned to this issue

[jamacku]

This sounds like a great idea. Thank you for submitting an issue.

[jamacku]

This issue should be resolved by #277. Unfortunately, I have no access to the GitHub Enterprise instance.

@lythro10, You can try it by using jamacku/advanced-issue-labeler@github-enterprise. It's for testing only.

[lythro10]

We have just tested github-enterprise branch. The issue is on the node version our runner runs on node16 , we have edited the action.yml to run on node16 we get the following error

"Error: fetch is not set. Please pass a fetch implementation as new Octokit({ request: { fetch }}). Learn more at https://github.com/octokit/octokit.js/#fetch-missing"

Error -- Octokit({ request: { fetch }}). - can be fixed by node18 or bypassed.

However, we have tested changing the base URL (hardcoded) and node set to node16 and it was working.

I believe it would be a better way to just set the base URL (API) and node version on the workflow yaml file.

[jamacku]

The issue is that Octokit switched from using the node-fetch library to using the standard Node.js fetch method. And since GitHub has started using Node.js 20 as the recommended runner, I have switched to it.

[jamacku]

I could start supporting two versions of this Action, one running on node16 and the other on node20, which should resolve all your issues.

[lythro10]

@jamacku any updates on the use of node16?

[jamacku]

@lythro10 I have created a new branch that is using node16. Please verify that v2.1.0 works for you.

[lythro10]

@jamacku Working great on v2.1.0

Thank you !