From 4d8082b7cb78b7e4acd977b141920064b2a14689 Mon Sep 17 00:00:00 2001
From: Jan Macku <jamacku@redhat.com>
Date: Fri, 3 May 2024 13:56:48 +0200
Subject: [PATCH] fix: simplify if statements in GHA workflows and in examples
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

follow-up to 723a7345bdf8f0a38d35b307d174de683b68fce1

Co-authored-by: Lukáš Zaoral <lzaoral@redhat.com>
---
 .github/workflows/differential-shellcheck.yml | 4 ++--
 README.md                                     | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/differential-shellcheck.yml b/.github/workflows/differential-shellcheck.yml
index e4f8a26..b3e1831 100644
--- a/.github/workflows/differential-shellcheck.yml
+++ b/.github/workflows/differential-shellcheck.yml
@@ -43,7 +43,7 @@ jobs:
             src/**.{zsh,osh}
           token: ${{ secrets.GITHUB_TOKEN }}
 
-      - if: ${{ always() }}
+      - if: always()
         name: Upload artifact with defects in SARIF format
         uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
         with:
@@ -51,7 +51,7 @@ jobs:
           path: ${{ steps.ShellCheck.outputs.sarif }}
           retention-days: 7
 
-      - if: ${{ always() }}
+      - if: always()
         name: Upload artifact with defects in XHTML format
         uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
         with:
diff --git a/README.md b/README.md
index 895f055..3b4edc0 100644
--- a/README.md
+++ b/README.md
@@ -96,7 +96,7 @@ jobs:
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
 
-      - if: ${{ always() }}
+      - if: always()
         name: Upload artifact with ShellCheck defects in SARIF format
         uses: actions/upload-artifact@v4
         with:
@@ -332,14 +332,14 @@ Relative path to SARIF file containing detected defects. Example of use:
   name: Differential ShellCheck
   uses: redhat-plumbers-in-action/differential-shellcheck@v5
 
-- if: ${{ always() }}
+- if: always()
   name: Upload artifact with ShellCheck defects in SARIF format
   uses: actions/upload-artifact@v4
   with:
     name: Differential ShellCheck SARIF
     path: ${{ steps.ShellCheck.outputs.sarif }}
 
-- if: ${{ always() }}
+- if: always()
   name: Upload SARIF to GitHub using github/codeql-action/upload-sarif
   uses: github/codeql-action/upload-sarif@v2
   with:
@@ -355,7 +355,7 @@ Relative path to HTML file containing detected defects. Example of use:
   name: Differential ShellCheck
   uses: redhat-plumbers-in-action/differential-shellcheck@v5
 
-- if: ${{ always() }}
+- if: always()
   name: Upload artifact with ShellCheck defects in HTML format
   uses: actions/upload-artifact@v4
   with: