Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Jaeger variables out of Dockerfile #161

Open
kameshsampath opened this issue Nov 12, 2018 · 0 comments
Open

Moving Jaeger variables out of Dockerfile #161

kameshsampath opened this issue Nov 12, 2018 · 0 comments

Comments

@kameshsampath
Copy link
Contributor

Currently the Jaeger variables are added as ENV in Docker file:

  ENV JAEGER_SERVICE_NAME=customer\
  JAEGER_ENDPOINT=http://jaeger-collector.istio-system.svc:14268/api/traces\
  JAEGER_PROPAGATION=b3\
  JAEGER_SAMPLER_TYPE=const\
  JAEGER_SAMPLER_PARAM=1

We could avoid this and add them to Kubernetes Deployment YAML

(OR)

Except for JAEGER_SERVICE_NAME other variables are pretty common for all the services, so all other variables could be added to ConfigMap and referred via configMapRef in Deployments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant