Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the grid spacing of items in the layout #4

Open
2 tasks
Spartee opened this issue Aug 8, 2022 · 6 comments
Open
2 tasks

Fix the grid spacing of items in the layout #4

Spartee opened this issue Aug 8, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Spartee
Copy link
Contributor

Spartee commented Aug 8, 2022

Description

The spacing of the grid in the application can sometimes be offset by the length of the text description for the product.

See example:
Screen Shot 2022-08-08 at 2 47 35 PM

TODO

  • Make a default container size for each product
  • Truncate text longer than allowed number of characters.
@Spartee Spartee added enhancement New feature or request good first issue Good for newcomers labels Aug 8, 2022
@Hammad-qadeer
Copy link

Hi there,

Can you please assign this to me? Would like to work on this issue.

@Spartee
Copy link
Contributor Author

Spartee commented Aug 10, 2022

HI @Hammad-qadeer! Thanks for the interest in contributing. We'd love that. We're drawing up a contributor agreement now, but I'll go ahead and assign the issue to you!

@Hammad-qadeer
Copy link

Hammad-qadeer commented Aug 16, 2022

Thanks for assigning this issue to me. I was kind of busy now I have tried to log in or SignIn but getting some errors.
image

@Spartee
Copy link
Contributor Author

Spartee commented Aug 29, 2022

Hi @Hammad-qadeer , we removed the sign and sign up as the demo is publicly available now. you shouldn't need to use the sign in to use the application now.

@Hammad-qadeer
Copy link

Hammad-qadeer commented Aug 29, 2022

Hi @Spartee it means now I could access it without getting logged in. I'll check again and let you know.

@tylerhutcherson
Copy link
Collaborator

@Hammad-qadeer are you able to access this now? Let us know if there's any issue. Thanks for being willing to contribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants