The link to OpenSSL::SSL::SSLContext#set_params in the README is not particularly helpful

[x-yuri]

https://github.com/redis-rb/redis-client/blob/v0.22.2/README.md#configuration
https://www.rubydoc.info/stdlib/openssl/OpenSSL%2FSSL%2FSSLContext:set_params

Maybe it was some time ago, but these days it's not.

The link provided by the openssl gem is.

Also I noticed a mysterious (supposedly) no-op line in the code:

        context.set_params(params)
        if context.verify_mode != OpenSSL::SSL::VERIFY_NONE
          if context.respond_to?(:verify_hostname) # Missing on JRuby
            context.verify_hostname  # O.o
          end
        end

        context

introduced here.

verify_hostname looks like a read-write attribute to me. According to the documentation and the code. Can you explain what it's doing?

[x-yuri]

I see, you provided a permalink, which kind of narrows on the method, not showing the rest:

https://www.rubydoc.info/stdlib/openssl/OpenSSL%2FSSL%2FSSLContext:set_params

Which is actually confusing. I think the following link would be better:

https://www.rubydoc.info/stdlib/openssl/OpenSSL/SSL/SSLContext#set_params-instance_method

I looked for the verify_hostname attribute, didn't found it there and started looking in the code.

[casperisfine]

If you think that part of the doc can be improved I'll accept a PR.

verify_hostname looks like a read-write attribute to me. According to the documentation and the code. Can you explain what it's doing?

I honestly don't remember why I did this, likely just a mistake that wasn't noticed because it's a noop.

[pboling]

But it looks like it shouldn't be a noop, doesn't it? Why is there a verify mode if not to verify?

if context.verify_mode != OpenSSL::SSL::VERIFY_NONE

Perhaps the verification is happening, but at a lower level, and the entire block is not needed here?