Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: activation command may get retried in a different connection, or failed due to queue full or dangled due to auto flush is false #2963

Open
okg-cxf opened this issue Aug 16, 2024 · 2 comments
Labels
status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-feedback We need additional information before we can continue

Comments

@okg-cxf
Copy link
Contributor

okg-cxf commented Aug 16, 2024

Bug Report

  1. activation command should never be retired in a different connection;
  2. activation command should never fail due to queue full;
  3. activation command should never get dangled in writeBuffer even if auto flush is false.

Refer to the MR for more details: https://github.com/redis/lettuce/pull/2962/files

Current Behavior

Stack trace
// your stack trace here;

Input Code

Input Code
// your code here;

Expected behavior/code

Environment

  • Lettuce version(s): [e.g. 5.0.0.RELEASE, 4.2.2.Final]
  • Redis version: [e.g. 4.0.9]

Possible Solution

Additional context

@tishun
Copy link
Collaborator

tishun commented Aug 30, 2024

Hey @okg-cxf ,

could we take a step back and talk a bit more about the use case you are handling?

Can you give a short example of the issue you are trying to solve? When does it occur?
Is there an easy way to reproduce it?

@tishun tishun added the status: waiting-for-feedback We need additional information before we can continue label Aug 30, 2024
Copy link

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 30 days this issue will be closed.

@github-actions github-actions bot added the status: feedback-reminder We've sent a reminder that we need additional information before we can continue label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: feedback-reminder We've sent a reminder that we need additional information before we can continue status: waiting-for-feedback We need additional information before we can continue
Projects
None yet
Development

No branches or pull requests

2 participants