Quit is not getting closed

[Senthilmj]

Description

Added this best practice for Node.js from this link (https://gist.github.com/JonCole/925630df72be1351b21440625ff2671f#file-redis-bestpractices-node-js-md). When we don't get a response within 30 seconds, we disconnect and reconnect Redis. The issue here is, after calling quit, no other code is executing. I'm not getting the Redis disconnected message in logger, so we're only throwing "Redis is not connected" message. Only a restart will fix the issue. Can anyone tell what the issue is here and what we can do to fix this?

        Logger.log(` Redis disconnecting`);
        await redisClient.quit();
        Logger.log(`Redis disconnected`);

Node.js Version

16.13.0

Redis Server Version

No response

Node Redis Version

4.5.1

Platform

Linux

Logs

No response

[lawfulsoftware]

QUIT is deprecated as of 7.2.0

The documentation should be updated.

[ivan-kleshnin]

We should use await client.disconnect(), right?

[leibale]

.quit closes the client gracefully (wait for all the commands before closing, but do not accept new ones) while .disconnect closes the client "forcefully" (will not wait for commands that are currently executed or in the queue). If you are using the legacyMode you might want to use client.v4.quit/client.v4.disconnect.