Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replicate source does not support --client #159

Closed
timothystewart6 opened this issue Sep 25, 2024 · 2 comments
Closed

replicate source does not support --client #159

timothystewart6 opened this issue Sep 25, 2024 · 2 comments

Comments

@timothystewart6
Copy link

timothystewart6 commented Sep 25, 2024

Hi. It seems that ping supports --client to set the client name (or unset my case). I need to unset the client with this arg because I don't have access to set this config in GCP on Redis Memorystore so the workaround is:

riot ping -u redis://10.213.18.228:6379 --client=""

This works great for ping however it looks like this argument is missing from replicate.

replicate supports --target-client but not --source-client or --client

This causes the command to throw an exception (just like using ping without --client="" in my case.

riot replicate --mode live --target-cluster redis://10.213.18.228:6379 redis://10.128.0.172:6379 --debug
...
Caused by: io.lettuce.core.RedisCommandExecutionException: ERR unknown command 'CLIENT', with args beginning with: 'SETNAME' 'RIOT4.1.4-SNAPSHOT'
	at io.lettuce.core.internal.ExceptionFactory.createExecutionException(ExceptionFactory.java:147)
	at io.lettuce.core.internal.ExceptionFactory.createExecutionException(ExceptionFactory.java:116)

if I could use --client or better yet --source-client argument to unset this for the source I can then run replicate

Ideally I would like to do this:

riot replicate --mode live --target-cluster --target-client="" --source-client="" redis://10.213.18.228:6379 redis://10.128.0.172:6379 --debug

I am using the v4.1.3 and even tried the early-access release. Neither support it.

Thank you!

@jruaux
Copy link
Collaborator

jruaux commented Sep 26, 2024

Thanks I just added a --source-client option

@jruaux jruaux closed this as completed Sep 26, 2024
@timothystewart6
Copy link
Author

Wow, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants