-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pushing metrics to prometheus #444
Comments
Hi @DestroyerAlpha, Does an otel prometheus exporter fit your needs? |
We are on go1.18 so probably would have to upgrade the go version for that as well, since it requires go1.20. Do we see a future plan to integrate it inhouse? |
Sorry, I didn’t get you. What did you mean by that? Or what kind of functionalities you need to integrate with your in-house infrastructure? |
I meant do we plan to export prom metric internally from rueidis instead of using an exporter? |
Oh, I see. Yes, we can have a So, there are two things we can do:
Would you like to help the first one? |
Sure I can help with the first one |
Added a PR for the same @rueian |
Hi @DestroyerAlpha, I would like to release the next v1.0.28 recently. Is there any chance of bringing the real implementation rueidisprom subpackage to life? Or I may need to revert it when releasing the next version. |
@rueian Hey would raise a PR for this ASAP. |
First of all thanks for constantly developing this library based on inputs from the community. I am glad to see that we have instrumented connection level metrics via rueidisotel. I was wondering if it would be possible to have a way to push these metrics to prometheus as well? Something like https://github.com/redis/go-redis/tree/master/extra/redisprometheus.
Would be happy to work on this, if needed, as well.
The text was updated successfully, but these errors were encountered: