Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnWriteTimeout doesn't appear to work. #811

Open
justinreddit opened this issue Mar 22, 2025 · 4 comments
Open

ConnWriteTimeout doesn't appear to work. #811

justinreddit opened this issue Mar 22, 2025 · 4 comments

Comments

@justinreddit
Copy link

We've specified ConnWriteTimeout, however, we observe client side latencies exceeding the timeout and not appearing to timeout. Are there client side metrics we can use to see whether this is getting triggered?

@rueian
Copy link
Collaborator

rueian commented Mar 22, 2025

Hi @justinreddit, please use context deadline instead https://github.com/redis/rueidis?tab=readme-ov-file#context-cancellation. For currently available metrics, please refer to https://github.com/redis/rueidis/tree/main/rueidisotel.

@liuzhaohui
Copy link
Contributor

We've specified ConnWriteTimeout, however, we observe client side latencies exceeding the timeout and not appearing to timeout. Are there client side metrics we can use to see whether this is getting triggered?

I encountered a similar issue under the senario of setting a context deadline for a request but occasionly it would take much more time until it realy returned. It's the issue of the connection dial didn't respect the context which fixed in recently release v1.0.56. May be you can try to use context deadline as mentioned above by rueian.

@justinreddit
Copy link
Author

@rueian any guidance on adding request latencies when using DoMulti? It'll be useful to see what client side latencies are per command.

@rueian
Copy link
Collaborator

rueian commented Mar 22, 2025

To see the latencies of commands, you can use rueidisotel to collect OpenTelemetry Traces. There will be latencies attached to each trace. If you want more customizations please refer to https://github.com/redis/rueidis/tree/main/rueidishook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants