Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC-766 add new 24.3 commands into cloud nav #133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

DOC-766 add new 24.3 commands into cloud nav #133

wants to merge 1 commit into from

Conversation

micheleRP
Copy link
Contributor

@micheleRP micheleRP commented Nov 21, 2024 •
edited
Loading

Description

Along with this PR Paulo did in the docs repo to single-source the new rpk commands for mountable topics, this adds those pages into the cloud-docs repo, so they're included in the Cloud nav.

Resolves https://redpandadata.atlassian.net/browse/DOC-766
Review deadline:

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for rp-cloud ready!

Name Link
🔨 Latest commit cffe43d
🔍 Latest deploy log https://app.netlify.com/sites/rp-cloud/deploys/673e856948f9bf0008323ffe
😎 Deploy Preview https://deploy-preview-133--rp-cloud.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@micheleRP micheleRP marked this pull request as ready for review November 21, 2024 01:10
@micheleRP micheleRP requested a review from a team as a code owner November 21, 2024 01:10
@micheleRP micheleRP mentioned this pull request Nov 21, 2024
Open
4 tasks
Feediver1
Feediver1 approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Feediver1 Feediver1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but need @Deflaimun's approval

Deflaimun
Deflaimun requested changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Deflaimun Deflaimun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can only be merged after 24.3 GAs. Blocking.

@AmanAsish-Partypresident AmanAsish-Partypresident mentioned this pull request Nov 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Deflaimun Deflaimun Deflaimun requested changes

@Feediver1 Feediver1 Feediver1 approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@micheleRP @Deflaimun @Feediver1