Skip to content

update boilerplate for connect & grpc-gateway #210

update boilerplate for connect & grpc-gateway

update boilerplate for connect & grpc-gateway #210

Triggered via pull request September 29, 2023 16:46
Status Failure
Total duration 1m 35s
Artifacts

backend-lint-test.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

9 errors and 11 warnings
verify: backend/pkg/api/grpc_gateway.go#L13
File is not `gci`-ed with --skip-generated -s standard,default,prefix(github.com/redpanda-data/console/backend) (gci)
verify: backend/pkg/api/grpc_gateway.go#L18
File is not `gci`-ed with --skip-generated -s standard,default,prefix(github.com/redpanda-data/console/backend) (gci)
verify: backend/pkg/api/connect/service/user/service.go#L72
commentedOutCode: may want to remove commented-out code (gocritic)
verify: backend/pkg/api/connect/service/user/service.go#L46
todoCommentWithoutDetail: may want to add detail/assignee to this TODO/FIXME/BUG comment (gocritic)
verify: backend/pkg/api/connect/interceptor/validation.go#L46
type switch on error will fail on wrapped errors. Use errors.As to check for specific errors (errorlint)
verify: backend/pkg/api/connect/interceptor/validation.go#L10
ST1000: at least one file in a package should have a package comment (stylecheck)
verify: backend/pkg/api/connect/service/user/mapper.go#L10
ST1000: at least one file in a package should have a package comment (stylecheck)
verify: backend/pkg/api/connect/service/user/service.go#L10
ST1000: at least one file in a package should have a package comment (stylecheck)
verify
issues found
verify: backend/pkg/api/connect/errors/domain.go#L13
exported: exported const DomainDataplane should have comment (or a comment on this block) or be unexported (revive)
verify: backend/pkg/api/connect/errors/errors.go#L19
exported: exported function NewConnectError should have comment or be unexported (revive)
verify: backend/pkg/api/connect/errors/errors.go#L42
exported: exported type KeyVal should have comment or be unexported (revive)
verify: backend/pkg/api/connect/errors/errors.go#L47
exported: exported function NewErrorInfo should have comment or be unexported (revive)
verify: backend/pkg/api/connect/errors/reason.go#L13
exported: exported const ReasonFeatureNotConfigured should have comment (or a comment on this block) or be unexported (revive)
verify: backend/pkg/api/connect/service/user/service.go#L45
unused-parameter: parameter 'req' seems to be unused, consider removing or renaming it as _ (revive)
verify: backend/pkg/api/connect/service/user/service.go#L128
unused-receiver: method receiver 's' is not referenced in method's body, consider removing or renaming it as _ (revive)
verify: backend/pkg/api/connect/service/user/service.go#L132
unused-receiver: method receiver 's' is not referenced in method's body, consider removing or renaming it as _ (revive)
verify: backend/pkg/api/connect/service/user/service.go#L29
exported: exported type Service should have comment or be unexported (revive)
verify: backend/pkg/api/connect/service/user/service.go#L36
exported: exported function NewService should have comment or be unexported (revive)
verify
Restore cache failed: Dependencies file is not found in /home/runner/work/console/console. Supported file pattern: go.sum