Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve path encoded subjects in middleware #1526

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Preserve path encoded subjects in middleware #1526

wants to merge 1 commit into from

Conversation

pkwarren
Copy link

Update basePathMiddleware to use RawPath (if present) over Path to ensure that URL path encoded subjects are preserved when routing requests.

Update the middleware to also remove the prefix from RawPath for consistency.

Fixes #1525.

@pkwarren
Preserve path encoded subjects in middleware
21a93fd 
Update basePathMiddleware to use `RawPath` (if present) over `Path` to
ensure that URL path encoded subjects are preserved when routing
requests.

Update the middleware to also remove the prefix from `RawPath` for
consistency.

Fixes redpanda-data#1525.
@CLAassistant
Copy link

CLAassistant commented Nov 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Non-default basePath causes issues with URL path escaped subject names
2 participants
@pkwarren @CLAassistant