Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect consumer groups data can't be disabled #243

Open
timchenko-a opened this issue Feb 8, 2024 · 1 comment
Open

Collect consumer groups data can't be disabled #243

timchenko-a opened this issue Feb 8, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@timchenko-a
Copy link

Hi,
I'd like to use Kminion only for E2E monitoring. So my config looks like this:

minion:
  consumerGroups:
    enabled: false
  topics:
    ignoredTopics: [ ".*" ]
  logDirs:
    enabled: false
  endToEnd:
    enabled: true

Based on the info from documentation, I assume it shouldn't try to get consumer groups from brokers. But it actually trying:
Kminion log example:

{"level":"warn","ts":"2024-02-08T12:56:07.910Z","logger":"main.minion_service","msg":"failed to fetch consumer group offsets, inner kafka error","consumer_group":"SOME_NON_KMINION_GROUP_NAME","error":"failed to request group offsets for group 'SOME_NON_KMINION_GROUP_NAME': GROUP_AUTHORIZATION_FAILED: Not authorized to access group: Group authorization failed."}

Kafka auth log:

{"short_message":"Principal = User:kminion is Denied Operation = Describe from host = EDITED on resource = Group:LITERAL:SOME_NON_KMINION_GROUP_NAME","full_message":"Principal = User:kminion is Denied Operation = Describe from host = EDITED on resource = Group:LITERAL:SOME_NON_KMINION_GROUP_NAME","timestamp":1.707396472924E9,"level":6,"facility":"logstash-gelf","LoggerName":"kafka.authorizer.logger","SourceSimpleClassName":"SimpleAclAuthorizer$BaseAuthorizer","SourceClassName":"kafka.security.auth.SimpleAclAuthorizer$BaseAuthorizer","Time":"2024-02-08 12:47:52,924","Severity":"INFO","SourceLineNumber":66,"Thread":"data-plane-kafka-request-handler-0","SourceMethodName":"logAuditMessage"}

I suspect this is due to collectConsumerGroupLags function not having enabled check, like e.g. in collectConsumerGroups .
I've also tried using ignoredGroups: [ ".*" ], but since offset request happens earlier this doesn't have any effect.

@weeco weeco added the bug Something isn't working label Mar 11, 2024
@timchenko-a
Copy link
Author

Hi @weeco , if this is actually a bug, not a feature, I can try working on this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants