From 8b21cd5e1cf6cf6801221ac67d4d2abcce841448 Mon Sep 17 00:00:00 2001 From: tcsola Date: Thu, 26 Sep 2024 13:21:04 +0900 Subject: [PATCH] refactor: resolve more advice by bot --- .../features/AccountAndWorkSpaceSetting/index.tsx | 9 ++------- .../AccountSetting/PasswordModal/index.tsx | 15 ++------------- .../innerPages/AccountSetting/index.tsx | 10 +++++----- 3 files changed, 9 insertions(+), 25 deletions(-) diff --git a/web/src/beta/features/AccountAndWorkSpaceSetting/index.tsx b/web/src/beta/features/AccountAndWorkSpaceSetting/index.tsx index 521df33db..6c3c0fa11 100644 --- a/web/src/beta/features/AccountAndWorkSpaceSetting/index.tsx +++ b/web/src/beta/features/AccountAndWorkSpaceSetting/index.tsx @@ -44,12 +44,7 @@ const AccountAndWorkSpaceSetting: FC = ({ tab }) => { return ( - + @@ -72,7 +67,7 @@ const AccountAndWorkSpaceSetting: FC = ({ tab }) => { )} diff --git a/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/PasswordModal/index.tsx b/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/PasswordModal/index.tsx index 14f3802b6..cb71d1a96 100644 --- a/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/PasswordModal/index.tsx +++ b/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/PasswordModal/index.tsx @@ -22,18 +22,7 @@ export type PasswordPolicy = { }; type Props = { - className?: string; - project?: { - id: string; - name: string; - isArchived: boolean; - }; - workspace?: { - id: string; - name: string; - }; isVisible: boolean; - archiveProject?: (archived: boolean) => void; onClose?: () => void; passwordPolicy?: PasswordPolicy; updatePassword?: ({ @@ -85,7 +74,7 @@ const PasswordModal: React.FC = ({ break; } }, - [t, password] // eslint-disable-line react-hooks/exhaustive-deps + [t, password, passwordPolicy] // eslint-disable-line react-hooks/exhaustive-deps ); const handleClose = useCallback(() => { @@ -171,7 +160,7 @@ const PasswordModal: React.FC = ({ - "repeatPassword" Passwords need to match. + {t('"repeatPassword" Passwords need to match')} ) : undefined} diff --git a/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/index.tsx b/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/index.tsx index f517b5e84..dc07fa66a 100644 --- a/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/index.tsx +++ b/web/src/beta/features/AccountAndWorkSpaceSetting/innerPages/AccountSetting/index.tsx @@ -16,8 +16,8 @@ import { InnerPage, SettingsWrapper, SettingsFields } from "../common"; import PasswordModal from "./PasswordModal"; type Props = { - imformationData: { name?: string; email?: string }; - passwordPolicy: PasswordPolicy; + informationData: { name?: string; email?: string }; + passwordPolicy?: PasswordPolicy; onUpdateUserPassword: ({ password, passwordConfirmation @@ -27,7 +27,7 @@ type Props = { const AccountSetting: FC = ({ passwordPolicy, onUpdateUserPassword, - imformationData + informationData }) => { const t = useT(); const [onPasswordModalClose, setPasswordModalOnClose] = @@ -40,13 +40,13 @@ const AccountSetting: FC = ({