Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some text is too dark #55

Open
Narotiza opened this issue Dec 2, 2024 · 5 comments
Open

Some text is too dark #55

Narotiza opened this issue Dec 2, 2024 · 5 comments

Comments

@Narotiza
Copy link

Narotiza commented Dec 2, 2024

there's some elements that are too darkly colored which makes them next to (if not entirely) impossible to read. i dunno if anyone else has this issue or if it's something on my end? i couldn't find anyone else talking about it
i'm using Vencord, with https://refact0r.github.io/system24/theme/system24.theme.css (nothing else) in the "online themes" section
image
image
image
image
image
^ this last one has some text that's entirely invisible, above the "show all participants" button

@Edga23
Copy link

Edga23 commented Dec 5, 2024

I believe --txt-dark is responsible for this text color and a very odd choice of first background color (--bg-0) was made. I just put --txt-dark: oklch(100% 0 0) in there, which is basically white. If you can't find it it's 40th line in the CSS file.

@Narotiza
Copy link
Author

Narotiza commented Dec 6, 2024

thanks for the suggestion! that seems to have fixed most things (all of my previous examples, i think), but made some others a bit worse? it's not too bad with white, which i'll be using for now (though it's overpowering in some other places), but some shades of light gray are pretty bad:

oklch(100% 0 0)

image
image

var(--text-1)

image
image

original:

image
image

i think the issue is that the color's being applied to the wrong elements, right? the css file says it's for dark text on colored backgrounds, like the 'new messages' banner, but it's also finding its way onto text on dark backgrounds (and some buttons in the call ui?)

unrelated to --text-dark, the color used for the 'hang up' icon doesn't go well with the pink background, and the play/pause and volume icons on the video player are really dark:
image

@Edga23
Copy link

Edga23 commented Dec 6, 2024

Yea, I think the creator of this theme has messed up something, as it clearly not only text this color is being applied to. I believe it would be possible to find the color with good contrast for all the above-mentioned examples, it just needs a bit of experimentation. If I will find free time I will also probably look into the main CSS file.

@Edga23
Copy link

Edga23 commented Dec 6, 2024

Looked into it bit and 896th looks like this: --white-500: var(--txt-dark); /* THE BANE OF MY EXISTENCE */. Perhaps it has something to do with it considering the comment, but I can't check it right now as I am not at home.
I would advise trying to override --white-500 color in the theme.css file. So --txt-dark leave as is and add to the end of the file --white-500: oklch(100% 0 0). Though I saw it being used 22 times in the main.css so perhaps it will be the same result.

@ribosomerocker
Copy link

The problem seems to already have been found, but for completeness' sake I reckon I'd mention that this also appears if you move the user volume slider after right clicking someone in VC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants