Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a search bar to header section #319

Open
s-gbz opened this issue Jul 3, 2020 · 1 comment
Open

Add a search bar to header section #319

s-gbz opened this issue Jul 3, 2020 · 1 comment

Comments

@s-gbz
Copy link

s-gbz commented Jul 3, 2020

Hi there,
I come back to your testing series quite frequently.
Today I noticed that I removed my bookmark, because I thought I was done with it (seems I wasn't).

It led me to notice that there's no option to search your site for specific content. Here's my proposal:
refelctoring-search-proposal

  • Looks clean
  • Easy to integrate
  • Additional user comfort

Check here for a live example using lua search engine.
I might as well create the PR if you'd like.

Cheers

PS: While preparing this issue I noticed that the header section disappears altogether on mobile view.
Is that intentional? Might be one issue more ;) :)

@s-gbz
Copy link
Author

s-gbz commented Jul 3, 2020

Actually there might be way more viable alternatives, e.g. https://github.com/nextapps-de/flexsearch <- supposed to be quite good as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant