Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REF-3630]Remove unsupported props from toast #26

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[REF-3630]Remove unsupported props from toast #26

merged 1 commit into from
Aug 27, 2024

Conversation

ElijahAhianyo
Copy link
Contributor

Toast component doesnt support the variant prop. According to the docs, all styles should either be placed in a style object for regular CSS or classNames for tailwind
https://sonner.emilkowal.ski/styling

@linear Linear
Copy link

linear bot commented Aug 27, 2024

REF-3630 [0.5.10 blocker] 1 validation error for ToastProps variant: extra fields not permitted (type=value_error.extra)

masenf
masenf approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@masenf masenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome

@masenf masenf merged commit a025b09 into main Aug 27, 2024
8 checks passed
@masenf masenf deleted the elijah/fix-toast branch August 27, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masenf masenf masenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ElijahAhianyo @masenf