Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff is not listed in the report #444

Open
sag1v opened this issue Mar 10, 2022 · 4 comments
Open

diff is not listed in the report #444

sag1v opened this issue Mar 10, 2022 · 4 comments
Labels

Comments

@sag1v
Copy link
Contributor

sag1v commented Mar 10, 2022

For some reason (sometimes) when i run the visual tests (using storycap for capturing the images) reg-cli logs a certain diff (which is a valid change) but when i run the update script, it logs that 2 files were updated. The issue here is that the 2nd file was not even listed in the report.

When i push the changes to GitLab i can see a diff, it seems like the file size is the only thing that is different (i'm not sure why though).

It doesn't happen all the time so its hard to understand what is causing it, maybe storycap has a bug or a config i am missing that makes it generate a different image size.

Note that i am running the tests in a docker, so i doubt its an environment issue.

This is how i run it:

yarn reg-cli somePath somePath somePath -R somePath/report.html --extendedErrors --matchingThreshold 0.1

image

@sag1v sag1v added the bug label Mar 10, 2022
@sag1v
Copy link
Contributor Author

sag1v commented Mar 14, 2022

@bokuweb Do you have an idea what can cause this?

@Jeiwan
Copy link

Jeiwan commented Mar 28, 2022

You have this parameter passed:
--matchingThreshold 0.1
Which increases the tolerance. Unset it to see the diff.

@sag1v
Copy link
Contributor Author

sag1v commented Apr 5, 2022

@Jeiwan Yeah i use it because sometimes i get random false positive diffing.

The issue is that when we run the update command it doesn't ignore those diffs, for example when you run the test it shows 1 file changed, then when you run the update it shows it updated 3 files and this is why i get the diff in git.

reg-cli should ignore those files and provide same results on testing and updating

When running the reg-cli for testing:
image

When running reg-cli for update:
image

@sag1v
Copy link
Contributor Author

sag1v commented Jul 30, 2022

@bokuweb Do you have any idea what can cause this behavior?

reg-cli run and show 1 file changed
reg-cli with update actually updates 3 files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants