Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong default parameter in function 'wct_significance' #52

Open
yetanotherfrancisdeveloper opened this issue Apr 21, 2023 · 0 comments
Open

Comments

@yetanotherfrancisdeveloper
Copy link

yetanotherfrancisdeveloper commented Apr 21, 2023

I think there is an error for the parameter 'wavelet' in the function 'wct_significance'. The docstring says it should be an instance of a class, but a string is given.

Function's parameter:

wavelet='morlet', mc_count=300, progress=True,

Docstring:

wavelet : instance of a wavelet class, optional

Edit: I should add that the function '_check_parameter_wavelet' is not used in 'wct_significance'. If one were to use this function with the default parameter, they would get an error. In fact, in the function 'cwt', the function '_check_parameter_wavelet' is used before using 'wct_significance'.

wavelet = _check_parameter_wavelet(wavelet)

sig = wct_significance(a1, a2, dt=dt, dj=dj, s0=s0, J=J,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant