Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Export the gocuke version in tests #15

Closed
0xste opened this issue Nov 17, 2023 · 2 comments
Closed

[feat] Export the gocuke version in tests #15

0xste opened this issue Nov 17, 2023 · 2 comments

Comments

@0xste
Copy link
Collaborator

0xste commented Nov 17, 2023

Proposing we expose the gocuke version via the api
I'd guess we'd just use debug.ReadBuildInfo() with a default for untagged versions
@0xste 0xste mentioned this issue Nov 17, 2023
Merged
@aaronc
Copy link
Member

aaronc commented Nov 20, 2023

Sounds reasonable.

@0xste
Copy link
Collaborator Author

0xste commented Nov 21, 2023

Closed as part of #18

@0xste 0xste closed this as completed Nov 21, 2023
0xste added a commit that referenced this issue Nov 21, 2023
@0xste @stefano-bd
chore: additional usage examples (#18)
4e290f5 
Addresses issues:
- #16
- #15

Additionally:
- Got rid of some linting errors from pre-commit hooks
- Couple of instances of shadowing, file access etc, largely minor

Co-authored-by: 0xste <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronc @0xste