Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way for cladetime users to specify a nextclade dataset version for custom clade assignments #69

Open
1 task
bsweger opened this issue Dec 10, 2024 · 0 comments

Comments

@bsweger
Copy link
Collaborator

bsweger commented Dec 10, 2024

Background

Currently, the CladeTime.assign_clades method determines which Nextclade SARS-CoV-2 dataset version to use for clade assignment by using the tree_as_of date:

  1. Get the version of https://nextstrain-data.s3.amazonaws.com/files/ncov/open/metadata_version.json that corresponds to tree_as_of
  2. The nextclade_dataset_version key of the above file is the dataset version that contains the reference tree used to assign clades in the Nextclade pipeline run on tree_as_of

This process ensures reproducibility when generating target data for variant-nowcast-hub. However, it means we can only do custom clade assignments back through August, 2024, when Nextstrain began publishing metadata_version.json

Request

For people who want to do custom clade assignments for dates prior to 2024-08-01, it would be helpful if Cladetime could accept a user-supplied SARS-CoV-2 dataset version instead of a tree-as-of date. In other words, allow users to supply the dataset version instead of having Cladetime look it up.

Definition of done

  • CladeTime.assign_clades works with a user-supplied SARS-CoV-2 dataset version in addition to its existing capability of retrieving the dataset version via tree_as_of
@bsweger bsweger added this to Lab Work Dec 10, 2024
@bsweger bsweger converted this from a draft issue Dec 10, 2024
@bsweger bsweger added this to the Variant Nowcast milestone Dec 10, 2024
@bsweger bsweger assigned bsweger and unassigned bsweger Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant