This repository has been archived by the owner on Jul 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Require that external URLs are prefixed with http or https #35
Labels
bug
Something isn't working
Comments
oh how dumb |
RIGHT?!
…On Sat, Jun 20, 2020 at 6:22 PM Paras Sanghavi ***@***.***> wrote:
oh how dumb
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BHVE57LL4CJZ6JO74463RXVOFJANCNFSM4ODT3J3Q>
.
|
disambiguator
added a commit
that referenced
this issue
Jun 21, 2020
Merged
@hartsick Check out the PR...this feels too easy, any edge cases I'm missing? |
I don't think so, since that should cover both http & https! can you toss
it on video_link, too, though (should be on master)?
just checked locally with my junk data and it looks good
…On Sat, Jun 20, 2020 at 6:32 PM Paras Sanghavi ***@***.***> wrote:
@hartsick <https://github.com/hartsick> Check out the PR...this feels too
easy, any edge cases I'm missing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#35 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4BHVBNVQJPYWMVUVJKRUDRXVPLVANCNFSM4ODT3J3Q>
.
|
hartsick
pushed a commit
that referenced
this issue
Jun 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Right now if we enter something like www.google.com into either our agenda_link or video_link fields, Rails treats those as relative paths and can't find the correct page.
To address this, we could either validate that those URLs start with http or https when entered, or just prefix the provided URLs with them before saving to the database.
[related to #29]
The text was updated successfully, but these errors were encountered: