Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weaponholders and wrecks don't get cleaned up #107

Open
rekterakathom opened this issue Mar 18, 2024 · 1 comment
Open

Weaponholders and wrecks don't get cleaned up #107

rekterakathom opened this issue Mar 18, 2024 · 1 comment
Labels
Performance Performance problem

Comments

@rekterakathom
Copy link
Owner

The only way that weaponholders ever get removed is by looting with AI or using the recovery truck, otherwise stuff is just going to remain forever. Wrecks are basically the same thing, except that nothing will ever clean them up, except for players with a toolkit. We could drastically reduce performance degradation by fixing these issues.

2.18 will introduce getCorpseWeaponHolders that can be implemented into the cleanup functions so that weapon holders get deleted alongside bodies. Though weaponholders not associated with a body will still remain...

There is also the issue that dead units that don't get looted will never be automatically deleted. Manual cleanup fixes this issue, but preferably the cleanup would work well enough that manual cleanup isn't needed.

2.18 will also introduce getEntityInfo that can be implemented into the OT_civilian_cleanup_crew action to check for really old bodies (90 mins, maybe?) to delete them.

@rekterakathom rekterakathom added the Performance Performance problem label Mar 18, 2024
@Tuupertunut
Copy link

Weaponholders dropped from bodies (WeaponHolderSimulated) seem to be automatically deleted when their body is deleted. Item piles on the ground (GroundWeaponHolder) are not deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Performance problem
Projects
None yet
Development

No branches or pull requests

2 participants