Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conversion from 'type' to 'type' function is illegal in every OS except Windows! #34

Open
JustinS-B opened this issue Nov 17, 2018 · 1 comment

Comments

@JustinS-B
Copy link
Contributor

JustinS-B commented Nov 17, 2018

Following the Microsoft Compiler Warning (level 4) C4239

The relativ_osvr_plugin/Relativ_OSVR_Plugin.cpp code fails to compile on any OS except Windows with this error:
error: cannot bind non-const lvalue reference of type ‘serial::Timeout&’ to an rvalue of type ‘serial::Timeout’

To resolve this, Кзобьтовскый created this fix:

Line 57
relativ.setTimeout(serial::Timeout::simpleTimeout(1000)); 

replace the whole of Line 57 with this:

serial::Timeout sto = serial::Timeout::simpleTimeout(1000);
relativ.setTimeout(sto);
yozaam added a commit to yozaam/relativ-osvr-plugin that referenced this issue Nov 30, 2018
issue #34 at relativty/Relativty#34

conversion from 'type' to 'type' function is illegal in every OS except Windows! #34
@penguindono
Copy link
Contributor

Will be tested and then merged, thank you yozaam ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants