From e01f60725a2640a61be9f589ffb744ef3c3b7027 Mon Sep 17 00:00:00 2001 From: Rohan McGovern Date: Tue, 14 Nov 2023 09:10:41 +1000 Subject: [PATCH] Drop mypy from "tox -e static" mypy started to complain with: pubtools/exodus/gateway.py:8: error: Library stubs not installed for "requests.packages.urllib3.util.retry" [import-untyped] pubtools/exodus/gateway.py:8: note: Hint: "python3 -m pip install types-requests" ...despite that types-requests *is* already installed. Other projects have seen similar issues. As we do not seem to detect any genuine issues with mypy in practice, let's drop it from the default CI configuration to reduce the CI maintenance cost. mypy currently remains in the test-requirements.txt file to enable running the tool locally. --- tox.ini | 1 - 1 file changed, 1 deletion(-) diff --git a/tox.ini b/tox.ini index 66c7cf0..55a77db 100644 --- a/tox.ini +++ b/tox.ini @@ -10,7 +10,6 @@ allowlist_externals=sh [testenv:static] commands= - mypy --install-types --non-interactive -p pubtools -p tests sh -c 'pylint pubtools; test $(( $? & (1|2|4|32) )) = 0' black --check . isort --check .