Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minReturn to sell and buy functions #1

Open
balasan opened this issue Mar 20, 2018 · 0 comments
Open

Add minReturn to sell and buy functions #1

balasan opened this issue Mar 20, 2018 · 0 comments

Comments

@balasan
Copy link
Contributor

balasan commented Mar 20, 2018

To prevent front-running attacks by miners, we should add a minReturn parameter to the buy and sell functions and appropriate tests.

The fallback contract should call buy(MAX_RETURN) where MAX_RETURN is some constant value putting a limit on how many tokens one can buy via fallback function — open to other options here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant